NallAway applied to spring-core

gistfile1.txt

> Task :spring-core:compileJava
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/metrics/DefaultApplicationStartup.java:56: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return null;
                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/ReactiveTypeDescriptor.java:101: error: [NullAway] dereferenced expression this.emptySupplier is @Nullable
                return this.emptySupplier.get();
                                         ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/Conventions.java:173: error: [NullAway] passing @Nullable parameter 'value' where @NonNull is required
                        return getVariableName(value);
                                               ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/ResolvableType.java:1443: error: [NullAway] dereferenced expression componentType.resolve() is @Nullable
                Class<?> arrayType = componentType.resolve().arrayType();
                                                            ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/CollectionFactory.java:202: error: [NullAway] passing @Nullable parameter 'elementType' where @NonNull is required
                        return EnumSet.noneOf(asEnumType(elementType));
                                                         ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/CollectionFactory.java:320: error: [NullAway] passing @Nullable parameter 'keyType' where @NonNull is required
                        return new EnumMap(asEnumType(keyType));
                                                      ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/codec/Decoder.java:111: error: [NullAway] dereferenced expression failure is @Nullable
                                new DecodingException("Failed to decode: " + failure.getMessage(), failure));
                                                                                    ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/io/buffer/DataBufferUtils.java:1086: error: [NullAway] dereferenced expression this.state.get() is @Nullable
                        if (this.state.get().equals(State.DISPOSED)) {
                                            ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/codec/ResourceDecoder.java:84: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                                        return filename;
                                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/codec/ResourceDecoder.java:96: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                                        return filename;
                                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/TypeDescriptor.java:605: error: [NullAway] passing @Nullable parameter 'element' where @NonNull is required
                return new TypeDescriptor(ResolvableType.forClassWithGenerics(collectionType, element), null, null);
                                                                                              ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/TypeDescriptor.java:631: error: [NullAway] passing @Nullable parameter 'key' where @NonNull is required
                return new TypeDescriptor(ResolvableType.forClassWithGenerics(mapType, key, value), null, null);
                                                                                       ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoader.java:397: error: [NullAway] passing @Nullable parameter '(Constructor<T>) constructor' where @NonNull is required
                        return new FactoryInstantiator<>((Constructor<T>) constructor);
                                                         ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/io/support/PathMatchingResourcePatternResolver.java:623: error: [NullAway] passing @Nullable parameter 'commonPrefix' where @NonNull is required
                                rootDirResources = getResources(commonPrefix);
                                                                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/io/support/PathMatchingResourcePatternResolver.java:631: error: [NullAway] dereferenced expression commonPrefix is @Nullable
                                else if (commonPrefix.equals(rootDirPath)) {
                                                     ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/io/support/PathMatchingResourcePatternResolver.java:837: error: [NullAway] dereferenced expression rootEntryPath is @Nullable
                                        String relativePath = entryPath.substring(rootEntryPath.length());
                                                                                               ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationAttributes.java:127: error: [NullAway] passing @Nullable parameter 'getAnnotationType(annotationType, classLoader)' where @NonNull is required
                this(getAnnotationType(annotationType, classLoader), false);
                                      ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationAttributes.java:352: error: [NullAway] passing @Nullable parameter 'value' where @NonNull is required
                assertAttributePresence(attributeName, value);
                                                       ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationAttributes.java:353: error: [NullAway] passing @Nullable parameter 'value' where @NonNull is required
                assertNotException(attributeName, value);
                                                  ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationAttributes.java:360: error: [NullAway] passing @Nullable parameter 'value' where @NonNull is required
                assertAttributeType(attributeName, value, expectedType);
                                                   ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationAttributes.java:361: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                return (T) value;
                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/RepeatableContainers.java:256: error: [NullAway] dereferenced expression otherErc is @Nullable
                        return (this.container.equals(otherErc.container) && this.repeatable.equals(otherErc.repeatable));
                                                              ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotatedMethod.java:282: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return AnnotatedMethod.this.getMethodAnnotation(annotationType);
                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationsScanner.java:138: error: [NullAway] dereferenced expression relevant is @Nullable
                                                for (int relevantIndex = 0; relevantIndex < relevant.length; relevantIndex++) {
                                                                                                    ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java:963: error: [NullAway] parameter attributes of referenced method is @NonNull, but parameter in functional interface method org.springframework.core.annotation.ValueExtractor.extract(java.lang.reflect.Method,java.lang.Object) is @Nullable
                                                AnnotationUtils::getAttributeValueForMirrorResolution);
                                                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java:990: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                return (result instanceof DefaultValueHolder defaultValueHolder ? defaultValueHolder.defaultValue : result);
                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java:130: error: [NullAway] parameter annotation of referenced method is @NonNull, but parameter in functional interface method org.springframework.core.annotation.ValueExtractor.extract(java.lang.reflect.Method,java.lang.Object) is @Nullable
                                mapping.getMirrorSets().resolve(source, this, this::getValueForMirrorResolution));
                                                                              ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java:325: error: [NullAway] passing @Nullable parameter '(Annotation) this.rootAttributes' where @NonNull is required
                if (isTargetAnnotation(this.rootAttributes) && !isSynthesizable((Annotation) this.rootAttributes)) {
                                                                                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java:326: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return (A) this.rootAttributes;
                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java:329: error: [NullAway] passing @Nullable parameter 'this.mapping.getAnnotation()' where @NonNull is required
                else if (isTargetAnnotation(this.mapping.getAnnotation()) && !isSynthesizable(this.mapping.getAnnotation())) {
                                                                                                                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java:330: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return (A) this.mapping.getAnnotation();
                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/SimpleAliasRegistry.java:192: error: [NullAway] dereferenced expression registeredName is @Nullable
                                else if (!registeredName.equals(resolvedName)) {
                                                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/type/classreading/SimpleAnnotationMetadataReadingVisitor.java:143: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                return this.metadata;
                ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/type/filter/AbstractTypeHierarchyTraversingFilter.java:83: error: [NullAway] passing @Nullable parameter 'metadata.getSuperClassName()' where @NonNull is required
                                                if (match(metadata.getSuperClassName(), metadataReaderFactory)) {
                                                                                    ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/IdToEntityConverter.java:74: error: [NullAway] dereferenced expression finder is @Nullable
                                source, sourceType, TypeDescriptor.valueOf(finder.getParameterTypes()[0]));
                                                                                 ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/CollectionToArrayConverter.java:72: error: [NullAway] dereferenced expression targetElementType is @Nullable
                Object array = Array.newInstance(targetElementType.getType(), sourceCollection.size());
                                                                  ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/ObjectToArrayConverter.java:66: error: [NullAway] dereferenced expression targetElementType is @Nullable
                Object target = Array.newInstance(targetElementType.getType(), 1);
                                                                   ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/ObjectToObjectConverter.java:139: error: [NullAway] passing @Nullable parameter 'executable' where @NonNull is required
                if (isApplicable(executable, sourceClass)) {
                                 ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/StringToPatternConverter.java:35: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return null;
                        ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/StringToArrayConverter.java:69: error: [NullAway] dereferenced expression targetElementType is @Nullable
                Object target = Array.newInstance(targetElementType.getType(), fields.length);
                                                                   ^
    (see http://t.uber.com/nullaway )
/Users/sdeleuze/workspace/spring-framework/spring-core/src/main/java/org/springframework/core/convert/support/StringToRegexConverter.java:34: error: [NullAway] returning @Nullable expression from method with @NonNull return type
                        return null;
                        ^
    (see http://t.uber.com/nullaway )
41 errors