-
-
Save lmammino/ef121da874a80d657379a1cd64bf8166 to your computer and use it in GitHub Desktop.
if (typeof Promise.withResolvers === 'undefined') { | |
Promise.withResolvers = function () { | |
let resolve, reject | |
const promise = new Promise((res, rej) => { | |
resolve = res | |
reject = rej | |
}) | |
return { promise, resolve, reject } | |
} | |
} | |
// Usage: | |
// const { promise, resolve, reject } = Promise.withResolvers() | |
// console.log(promise, resolve, reject) // Promise { <pending> } [Function (anonymous)] [Function (anonymous)] | |
// ... Do something async and then call resolve or reject! |
This is better:
if (!Promise.withResolvers) {
Promise.withResolvers = function() {
let resolve, reject;
const promise = new Promise((res, rej) => {
resolve = res;
reject = rej;
});
// wait a bit
while (resolve === undefined || reject === undefined) {}
return { promise, resolve, reject };
};
}
Hello @aralroca,
Thanks for submitting this, but be aware that the executor function (the function you pass to the Promise
constructor) is executed synchronously, as soon as the promise is constructed, so there's no way for resolve
or reject
to be undefined. (source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/Promise#:~:text=The%20executor%20is%20called%20synchronously%20(as%20soon%20as%20the%20Promise%20is%20constructed)%20with%20the%20resolveFunc%20and%20rejectFunc%20functions%20as%20arguments.)
For example this code should work as intended:
Promise.withResolvers = function () {
let resolve, reject
const promise = new Promise((res, rej) => {
resolve = res
reject = rej
})
return { promise, resolve, reject }
}
const { promise, resolve, reject } = Promise.withResolvers()
console.log(resolve, reject) // synchronously check the value of `resolve` and `reject`
promise.then(console.log)
resolve('Hello, world!')
It prints:
[Function (anonymous)] [Function (anonymous)]
Hello, world!
Moreover, I would strongly discourage using for
or while
loops (or other synchronous mechanisms) to wait for asynchronous operations to progress. You would just risk to block the event loop indefinitely...
I hope this makes sense.
It depends on the runtime, I had issues with Node 20
It depends on the runtime, I had issues with Node 20
I just tested the snippet above with Node 20 and, as far as I can tell, it behaves as expected.
I hope the issue you describe is not runtime-dependent, because that would mean that the specific runtime is not spec-compliant.
Do you have an example I can try to run that illustrates the problem?
@lmammino this is not working:
Object.assign(Promise, {
withResolvers: () => {
let resolve;
let reject;
const promise = new Promise((resolve, reject) => {
resolve = resolve;
reject = reject;
});
return {
promise,
resolve,
reject
};
}});
const a = Promise.withResolvers()
a.promise.then(() => console.log('resolved'))
a.resolve();
With this error:
VM717:20 Uncaught TypeError: a.resolve is not a function
at <anonymous>:20:3
But I see that it is because of the name that I am reassigning the variable inside the function, not the one outside. It's totally my fault. Sorry about that.
A TypeScript version:
if (typeof Promise.withResolvers === "undefined") {
Promise.withResolvers = <T>() => {
let resolve: (value: T | PromiseLike<T>) => void;
let reject: (reason?: unknown) => void;
const promise = new Promise<T>((res, rej) => {
resolve = res;
reject = rej;
});
return { promise, resolve: resolve!, reject: reject! };
};
}
The problem of this solution is that calling
resolve
can not exist yet!